Stop using rest-api-spec #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pquentin merged 9 commits into main from stop-using-rest-api-spec

Dec 12, 2025

Member

pquentin commented Dec 10, 2025 •

edited

Loading

Closes #5304

pquentin added 8 commits

December 10, 2025 11:02


          Remove reAddAvailability function

450c102


          Remove jsonSpec as a global variable

a105a28

This makes it easier to spot functions that use it.


          Stop reading endpoints from jsonSpec

ae54697


          Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and avail…

d3cdec5

…ability from rest-api-spec


          Stop reading description and urls from rest-api-spec

a23b6bc


          Stop validating rest-api-spec

a31c509


          Stop using jsonSpec in compilation steps

512d772


          Stop using rest-api-spec altogether

82886c3

pquentin added backport 8.19 backport 9.1 labels

pquentin requested review from a team as code owners

December 10, 2025 07:29

pquentin added the backport 9.2 label

pquentin requested a review from a team as a code owner

December 10, 2025 07:29

github-actions bot added specification compiler labels

Contributor

github-actions bot commented Dec 10, 2025 •

edited

Loading

Following you can find the validation changes against the target branch for the API.

API	Status	Request	Response
`inference.put_groq`	➕ ⚪	Missing test	Missing test

You can validate this API yourself by using the make validate target.

JoshMock approved these changes

View reviewed changes

Member

JoshMock left a comment

So much red! 😮

Member

flobernd commented Dec 10, 2025

Great achievement 🥳

A single CI check seems to fail.


          Fix compiler tests

54de823

pquentin mentioned this pull request

Refactor compiler model building #5832

Open

pquentin merged commit 18a4c3f into main

12 checks passed

pquentin deleted the stop-using-rest-api-spec branch

December 12, 2025 06:41

Contributor

github-actions bot commented Dec 12, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5831-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5831-to-8.19.

Contributor

github-actions bot commented Dec 12, 2025

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5831-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5831-to-9.1.

Contributor

github-actions bot commented Dec 12, 2025

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5831-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5831-to-9.2.

pquentin added backport 8.19 and removed backport 8.19 backport 9.1 backport 9.2 labels

pquentin added backport 9.1 backport 9.2 labels

Contributor

github-actions bot commented Dec 12, 2025

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5831-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5831-to-9.1.

Contributor

github-actions bot commented Dec 12, 2025

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5831-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5831-to-9.2.

Contributor

github-actions bot commented Dec 12, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5831-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5831-to-8.19.

pquentin added a commit that referenced this pull request


          Stop using rest-api-spec (#5831)

532b04f

* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json

pquentin mentioned this pull request

[9.2] Stop using rest-api-spec (#5831) #5840

Merged

pquentin added a commit that referenced this pull request


          Stop using rest-api-spec (#5831)

1ebfd66

* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json

pquentin mentioned this pull request

[9.1] Stop using rest-api-spec (#5831) #5841

Merged

Member Author

pquentin commented Dec 12, 2025

💔 Some backports could not be created

Status	Branch	Result
✅	9.2
✅	9.1
❌	8.19	Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 5831

Questions ?

Please refer to the Backport tool documentation

Member Author

pquentin commented Dec 12, 2025

Not going to do 8.19.

pquentin added a commit that referenced this pull request


          Stop using rest-api-spec (#5831) (#5840)

434fcc4

* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json

pquentin added a commit that referenced this pull request


          Stop using rest-api-spec (#5831) (#5841)

55018dd

* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 8.19 backport 9.1 backport 9.2 compiler specification